Removed shmop test leaking an shm segment

laumin · Mar 30, 2016 · 3bfe1c5 · 3bfe1c5
1 parent ed06d13
commit 3bfe1c5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 33 deletions.
diff --git a/ext/shmop/shmop.c b/ext/shmop/shmop.c
@@ -203,6 +203,7 @@ PHP_FUNCTION(shmop_open)
 	}
 
 	if (shmctl(shmop->shmid, IPC_STAT, &shm)) {
+		/* please do not add coverage here: the segment would be leaked and impossible to delete via php */
 		php_error_docref(NULL, E_WARNING, "unable to get shared memory segment information '%s'", strerror(errno));
 		goto err;
 	}

diff --git a/ext/shmop/tests/003.phpt b/ext/shmop/tests/003.phpt