Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix release type, update package version. #27

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

kinyoklion
Copy link
Member

No description provided.

@@ -15,7 +15,6 @@ jobs:
id: release
with:
token: ${{secrets.GITHUB_TOKEN}}
release-type: "go"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong and caused the package.json not to be updated.

@@ -1,6 +1,6 @@
{
"name": "launchdarkly-eventsource",
"version": "2.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is needed for a manual publish.

@kinyoklion kinyoklion marked this pull request as ready for review April 26, 2024 17:17
@kinyoklion kinyoklion requested a review from a team April 26, 2024 17:17
@kinyoklion kinyoklion changed the title chore: Implement release please. chore: Fix release type, update package version. Apr 26, 2024
@kinyoklion kinyoklion merged commit ada7031 into main Apr 26, 2024
2 checks passed
@kinyoklion kinyoklion deleted the rlamb/fixup-release branch April 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants