MDL-69119 qformat_xml: fix mc calculated export

The Moodle XML export of multiple choice calculated questions was missing proper escaping of answers. Also the indentation of the generated xml was off. Signed-off-by: Daniel Ziegenberg <[email protected]>
laurentdavid · Oct 3, 2023 · 55ef055 · 55ef055
1 parent 43d5aec
commit 55ef055
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/question/format/xml/format.php b/question/format/xml/format.php
@@ -1437,20 +1437,20 @@ public function writequestion($question) {
 
                 foreach ($question->options->answers as $answer) {
                     $percent = 100 * $answer->fraction;
-                    $expout .= "<answer fraction=\"{$percent}\">\n";
+                    $expout .= "    <answer fraction=\"{$percent}\">\n";
                     // The "<text/>" tags are an added feature, old files won't have them.
-                    $expout .= "    <text>{$answer->answer}</text>\n";
-                    $expout .= "    <tolerance>{$answer->tolerance}</tolerance>\n";
-                    $expout .= "    <tolerancetype>{$answer->tolerancetype}</tolerancetype>\n";
-                    $expout .= "    <correctanswerformat>" .
+                    $expout .= $this->writetext($answer->answer, 3);
+                    $expout .= "      <tolerance>{$answer->tolerance}</tolerance>\n";
+                    $expout .= "      <tolerancetype>{$answer->tolerancetype}</tolerancetype>\n";
+                    $expout .= "      <correctanswerformat>" .
                             $answer->correctanswerformat . "</correctanswerformat>\n";
-                    $expout .= "    <correctanswerlength>" .
+                    $expout .= "      <correctanswerlength>" .
                             $answer->correctanswerlength . "</correctanswerlength>\n";
-                    $expout .= "    <feedback {$this->format($answer->feedbackformat)}>\n";
-                    $expout .= $this->writetext($answer->feedback);
+                    $expout .= "      <feedback {$this->format($answer->feedbackformat)}>\n";
+                    $expout .= $this->writetext($answer->feedback, 4);
                     $expout .= $this->write_files($this->feedbackfiles[$answer->id]);
-                    $expout .= "    </feedback>\n";
-                    $expout .= "</answer>\n";
+                    $expout .= "      </feedback>\n";
+                    $expout .= "    </answer>\n";
                 }
                 if (isset($question->options->unitgradingtype)) {
                     $expout .= "    <unitgradingtype>" .