Better re-rendering on quick-edit #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this saves us from re-rendering an entire document when quick editing just a portion if chp_1__sec_1 is quick edited, then the mutation target will be chp_1 and so all of chp_1 is re-rendered. We could be smarter and only re-render chp_1__sec_1, but it gets more complicated. We would then have to detect if the mutation impacts other siblings (eg. the section was split into two) or if it was deleted.
this lets us handle the common case of a quick-edited element being changed (with the eid not changing), meaning we can re-render just that element
|
I've made this smarter to handle the common case of editing just the quick edited portion. |
|
Fixes #2329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the common case of a quick-edit without an eid change, the quick-edited element is replaced.
In the other case where the eid changes or for some reason another portion of the tree changes, then the target of the mutation (If chp_1__sec_1 is quick edited, then the mutation target will be chp_1) is re-rendered.
This also fixes a bug where changing the eid and then deleting the portion would nuke the whole document.
https://www.loom.com/share/a64501a5e30d4118a3f12b3bf90d80d9