Correct reactive power device class #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N3rdix
temporarily deployed
to
continuous-integration
GitHub Actions
Inactive
|
Suggest amending energy to exclude energy.r from getting a device class. |
N3rdix
temporarily deployed
to
continuous-integration
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
+ Coverage 94.30% 94.31% +0.01%
==========================================
Files 12 12
Lines 1931 1935 +4
==========================================
+ Hits 1821 1825 +4
Misses 110 110 ☔ View full report in Codecov by Sentry. |
drc38
approved these changes
Dec 1, 2024
lbbrhzn
pushed a commit
that referenced
this pull request
Jan 5, 2025
* fix state_class * add test for reactive sensor * Revert test_init.py * Add HA unit * Add OCPP to HA unit mapping * add assert vor reactive unit * add separate sensor test --------- Co-authored-by: drc38 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1403 partially by giving a device class for reactive power sensors.
There is no device class for reactive energy so far, means this cannot be fixed and does not have a device class assigned on purpose: https://developers.home-assistant.io/docs/core/entity/sensor/
Once HA provides a device class for it it can be added here...