Prerelease

[drc38]

No description provided.

[drc38]

@ars3niy can you take a look at why v2.0.1 tests fail with the latest ocpp release candidate please.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (78a9f2a) to head (0baf9c0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          12       12           
  Lines        1935     1935           
=======================================
  Hits         1825     1825           
  Misses        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ars3niy]

@ars3niy can you take a look at why v2.0.1 tests fail with the latest ocpp release candidate please.

It failed because _get_inventory from ocppv201.py appeared to return before NotifyReport without "tbc":true was received. How this was possible, I have no idea right now, it does not happen when I run locally.

[ars3niy]

This is where it waits for "tbc":true to disappear:

        if not kwargs.get("tbc", False):
            self._wait_inventory.set()

It is as if it did not see the tbc parameter when it was there.

[drc38]

This is where it waits for "tbc":true to disappear:

        if not kwargs.get("tbc", False):
            self._wait_inventory.set()

It is as if it did not see the tbc parameter when it was there.

It looks like it has something to do with threading and schema validation given disabling using the thread executor pool for validation resolves the error.

Could you please update your code to use the non-deprecated Action enums eg Action.get_base_report vs Action.GetBaseReport as they are going to be removed in release 2.0.0

[ars3niy]

Incidentally, since you consider this code to be mine, please send e-mail to arseniy.lartsev at qodes.se if there are any further issues. I may not immediately notice or else quickly forget things otherwise.

[drc38]

Incidentally, since you consider this code to be mine, please send e-mail to arseniy.lartsev at qodes.se if there are any further issues. I may not immediately notice or else quickly forget things otherwise.

Thanks @ars3niy, I get emailed directly when mentioned in a github comment do you not? Is there some other way to include your email in a comment to trigger an email?