fix(login-form): Login dialog not opening properly after external close.

When the login dialog is closed by clicking on the backdrop, it was not properly removing the loginDialog object so the next time it failed to open the login form.

client/src/common/security/security.js

@@ -16,18 +16,19 @@ angular.module('security.service', [
   // Login form dialog stuff
   var loginDialog = null;
   function openLoginDialog() {
-    if ( !loginDialog ) {
-      loginDialog = $dialog.dialog();
-      loginDialog.open('security/login/form.tpl.html', 'LoginFormController').then(onLoginDialogClose);
+    if ( loginDialog ) {
+      throw new Error('Trying to open a dialog that is already open!');
     }
+    loginDialog = $dialog.dialog();
+    loginDialog.open('security/login/form.tpl.html', 'LoginFormController').then(onLoginDialogClose);
   }
   function closeLoginDialog(success) {
     if (loginDialog) {
       loginDialog.close(success);
-      loginDialog = null;
     }
   }
   function onLoginDialogClose(success) {
+    loginDialog = null;
     if ( success ) {
       queue.retryAll();
     } else {
@@ -108,4 +109,4 @@ angular.module('security.service', [
   };
 
   return service;
-}]);
+}]);