Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time events in ETS model with heat recovery chiller #4059

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

mwetter
Copy link
Member

@mwetter mwetter commented Nov 23, 2024

This closes #4058
It also removes a duplicate signal connection.

@mwetter mwetter added this to the Release 12.0.0 milestone Nov 23, 2024
@mwetter mwetter added the non-backward compatible Non-backward compatible changes label Nov 23, 2024
@mwetter
Copy link
Member Author

mwetter commented Nov 23, 2024

@AntoineGautier : Can you please have a brief look into this refactoring. It replaces a FirstOrderHold with 60 s sampling time with a TrueFalseHold and a Pre at its input. The TrueFalseHold avoids the frequent time events and the Pre is needed for OpenModelica to avoid a nonlinear equation in a when construct during the initialization.

@AntoineGautier
Copy link
Contributor

The change looks good to me.
In addition, I suggest increasing the minimum cycle time from 60 s to 5 min. This has minimal impact on the supply temperatures and avoids cycling the two HX pumps every 60 s, which seems a little demanding.
I committed this modification via the last two commits. The comparison results can be downloaded from here:
https://drive.google.com/file/d/1uEiDJpI6ymrWTNUKxW2WFFKu6d5cGJZS/view?usp=drive_link
Extract archive and run python -c "import buildingspy.development.regressiontest as t; t.Tester(tool=\"dymola\").report()" to visualize.

@mwetter
Copy link
Member Author

mwetter commented Nov 25, 2024

@AntoineGautier : Thanks, increasing it to 5 min is good.

@mwetter mwetter merged commit 32156a1 into master Nov 25, 2024
3 checks passed
@mwetter mwetter deleted the issue4058_ets_timeEvents branch November 25, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-backward compatible Non-backward compatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce time events in DHC.ETS.Combined.ChillerOnly (and related models)
2 participants