Skip to content

Commit

Permalink
net: stmmac: cleared __FPE_REMOVING bit in stmmac_fpe_start_wq()
Browse files Browse the repository at this point in the history
An issue found when network interface is down and up again, FPE handshake
fails to trigger. This is due to __FPE_REMOVING bit remains being set in
stmmac_fpe_stop_wq() but not cleared in stmmac_fpe_start_wq(). This
cause FPE workqueue task, stmmac_fpe_lp_task() not able to be executed.

To fix this, add clearing __FPE_REMOVING bit in stmmac_fpe_start_wq().

Fixes: 5a55861 ("net: stmmac: support FPE link partner hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Mohammad Athari Bin Ismail authored and davem330 committed Apr 30, 2021
1 parent d4eecfb commit db7c691
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3180,6 +3180,7 @@ static int stmmac_fpe_start_wq(struct stmmac_priv *priv)
char *name;

clear_bit(__FPE_TASK_SCHED, &priv->fpe_task_state);
clear_bit(__FPE_REMOVING, &priv->fpe_task_state);

name = priv->wq_name;
sprintf(name, "%s-fpe", priv->dev->name);
Expand Down

0 comments on commit db7c691

Please sign in to comment.