Merge pull request iterative#470 from efiop/master

output: don't forget to check inode when using cached state for changed() method
lcajachahua · Feb 15, 2018 · 5b588d9 · 5b588d9
2 parents f46af79 + 3624019
commit 5b588d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/dvc/output.py b/dvc/output.py
@@ -68,7 +68,7 @@ def _changed_md5(self):
             return True
 
         state = self.project.state.get(self.path)
-        if state and state.mtime == self.mtime():
+        if state and state.mtime == self.mtime() and state.inode == self.inode():
             md5 = state.md5
         else:
             md5 = self.compute_md5()

diff --git a/dvc/stage.py b/dvc/stage.py
@@ -68,6 +68,8 @@ def changed(self):
             if entry.changed():
                 self.project.logger.debug("{} changed".format(self.path))
                 return True
+            else:
+                self.project.logger.debug("{} didn't change".format(self.path))
         return False
 
     def remove_outs(self):