Removed ability to disable connection pool (apache#337)

ldlzp · Apr 17, 2017 · 6099e88 · 6099e88
1 parent df34ae7
commit 6099e88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/pulsar-client/src/main/java/com/yahoo/pulsar/client/api/ClientConfiguration.java b/pulsar-client/src/main/java/com/yahoo/pulsar/client/api/ClientConfiguration.java
@@ -211,12 +211,13 @@ public int getConnectionsPerBroker() {
      * By default, the connection pool will use a single connection for all the producers and consumers. Increasing this
      * parameter may improve throughput when using many producers over a high latency connection.
      * <p>
-     * Setting connections per broker to 0 will disable the connection pooling.
      *
      * @param connectionsPerBroker
-     *            max number of connections
+     *            max number of connections per broker (needs to be greater than 0)
      */
     public void setConnectionsPerBroker(int connectionsPerBroker) {
+        checkArgument(connectionsPerBroker > 0,
+                "Connections per broker need to be greater than 0");
         this.connectionsPerBroker = connectionsPerBroker;
     }
 

diff --git a/pulsar-testclient/src/main/java/com/yahoo/pulsar/testclient/PerformanceConsumer.java b/pulsar-testclient/src/main/java/com/yahoo/pulsar/testclient/PerformanceConsumer.java
@@ -84,7 +84,7 @@ static class Arguments {
 
         @Parameter(names = { "-c",
                 "--max-connections" }, description = "Max number of TCP connections to a single broker")
-        public int maxConnections = 0;
+        public int maxConnections = 100;
 
         @Parameter(names = { "-i",
                 "--stats-interval-seconds" }, description = "Statistics Interval Seconds. If 0, statistics will be disabled")

diff --git a/pulsar-testclient/src/main/java/com/yahoo/pulsar/testclient/PerformanceProducer.java b/pulsar-testclient/src/main/java/com/yahoo/pulsar/testclient/PerformanceProducer.java
@@ -111,7 +111,7 @@ static class Arguments {
 
         @Parameter(names = { "-c",
                 "--max-connections" }, description = "Max number of TCP connections to a single broker")
-        public int maxConnections = 0;
+        public int maxConnections = 100;
 
         @Parameter(names = { "-m",
                 "--num-messages" }, description = "Number of messages to publish in total. If 0, it will keep publishing")