Improve permission check

lduchosal · Nov 2, 2022 · d5ac6aa · d5ac6aa
1 parent 87d5432
commit d5ac6aa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/org/traccar/api/security/PermissionsService.java b/src/main/java/org/traccar/api/security/PermissionsService.java
@@ -104,7 +104,7 @@ public void checkEdit(long userId, Class<?> clazz, boolean addition) throws Stor
             } else if (clazz.equals(Device.class)) {
                 denied = getServer().getDeviceReadonly() || getUser(userId).getDeviceReadonly()
                         || addition && getUser(userId).getDeviceLimit() == 0;
-                if (addition && getUser(userId).getDeviceLimit() > 0) {
+                if (!denied && addition && getUser(userId).getDeviceLimit() > 0) {
                     int deviceCount = storage.getObjects(Device.class, new Request(
                             new Columns.Include("id"),
                             new Condition.Permission(User.class, userId, Device.class))).size();