Skip to content

Commit

Permalink
doc: trim GitHub template comments
Browse files Browse the repository at this point in the history
Make the comments in the GitHub templates slightly more concise.

PR-URL: nodejs#6755
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
  • Loading branch information
Trott committed May 17, 2016
1 parent ffc708d commit 42ede93
Showing 2 changed files with 10 additions and 17 deletions.
13 changes: 5 additions & 8 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
<!--
Thanks for wanting to report an issue you've found in Node.js. Please fill in
the template below by replacing the html comments with an appropriate answer.
If unsure about something, just do as best as you're able.
Thank you for reporting an issue. Please fill in the template below. If unsure
about something, just do as best as you're able.
version: usually output of `node -v`
platform: either `uname -a` output, or if Windows, version and 32 or 64-bit.
subsystem: optional -- if known please specify affected core module name.
Version: usually output of `node -v`
Platform: either `uname -a` output, or if Windows, version and 32 or 64-bit
Subsystem: if known, please specify affected core module name
It will be much easier for us to fix the issue if a test case that reproduces
the problem is provided. Ideally this test case should not have any external
dependencies. We understand that it is not always possible to reduce your code
to a small test case, but we would appreciate to have as
much data as possible.
Thank you!
-->

* **Version**:
14 changes: 5 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
<!--
Thank you for submitting a pull request to Node.js. Before you submit, please
review below requirements and walk through the checklist. You can 'tick'
a box by using the letter "x": [x].
Thank you for your pull request. Please review below requirements and walk
through the checklist. You can 'tick' a box by using the letter "x": [x].
Run the test suite by invoking: `make -j4 lint test` on linux or
`vcbuild test nosign` on Windows.
Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on
Windows.
If this aims to fix a regression or you’re adding a feature, make sure you also
write a test. Finally – if possible a benchmark that quantifies your changes.
write a test. If possible, include a benchmark that quantifies your changes.
Finally, read through our contributors guide and make adjustments as necessary:
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist

<!-- remove lines that do not apply to you -->

- [ ] tests and code linting passes
@@ -24,10 +22,8 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md


##### Affected core subsystem(s)

<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->


##### Description of change

<!-- provide a description of the change below this comment -->

0 comments on commit 42ede93

Please sign in to comment.