Skip to content

Commit

Permalink
build: do not ignore errors during build-addons
Browse files Browse the repository at this point in the history
Errors during build-addons were being silently ignored.

PR-URL: nodejs#5494
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
  • Loading branch information
ofrobots authored and Ali Sheikh committed Mar 4, 2016
1 parent 536cfec commit 8cf9400
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp
for dirname in test/addons/*/; do \
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
--directory="$$PWD/$$dirname" \
--nodedir="$$PWD"; \
--nodedir="$$PWD" || exit 1 ; \
done
touch $@

Expand Down

0 comments on commit 8cf9400

Please sign in to comment.