tools: prohibit notDeepEqual usage

PR-URL: nodejs#16325
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

.eslintrc.yaml

@@ -56,6 +56,9 @@ rules:
     - object: assert
       property: deepEqual
       message: Use assert.deepStrictEqual().
+    - object: assert
+      property: notDeepEqual
+      message: Use assert.notDeepStrictEqual().
     - object: assert
       property: equal
       message: Use assert.strictEqual() rather than assert.equal().

lib/assert.js

@@ -101,20 +101,20 @@ assert.deepEqual = function deepEqual(actual, expected, message) {
     innerFail(actual, expected, message, 'deepEqual', deepEqual);
   }
 };
-/* eslint-enable */
-
-assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
-  if (!isDeepStrictEqual(actual, expected)) {
-    innerFail(actual, expected, message, 'deepStrictEqual', deepStrictEqual);
-  }
-};
 
 // The non-equivalence assertion tests for any deep inequality.
 assert.notDeepEqual = function notDeepEqual(actual, expected, message) {
   if (isDeepEqual(actual, expected)) {
     innerFail(actual, expected, message, 'notDeepEqual', notDeepEqual);
   }
 };
+/* eslint-enable */
+
+assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
+  if (!isDeepStrictEqual(actual, expected)) {
+    innerFail(actual, expected, message, 'deepStrictEqual', deepStrictEqual);
+  }
+};
 
 assert.notDeepStrictEqual = notDeepStrictEqual;
 function notDeepStrictEqual(actual, expected, message) {