buffer: buffer.transcode to use internal/errors

`buffer.transcode` is still using raw TypeError. This change is to convert it to use internal/errors. Ref: nodejs#11273 PR-URL: nodejs#16352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
leak4mk0 · Oct 23, 2017 · e79a61c · e79a61c
1 parent f1d6b04
commit e79a61c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -1562,7 +1562,8 @@ if (process.binding('config').hasIntl) {
   // Buffer instance.
   transcode = function transcode(source, fromEncoding, toEncoding) {
     if (!isUint8Array(source))
-      throw new TypeError('"source" argument must be a Buffer or Uint8Array');
+      throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'source',
+                                 ['Buffer', 'Uint8Array'], source);
     if (source.length === 0) return Buffer.alloc(0);
 
     fromEncoding = normalizeEncoding(fromEncoding) || fromEncoding;

diff --git a/test/parallel/test-icu-transcode.js b/test/parallel/test-icu-transcode.js
@@ -41,9 +41,14 @@ for (const test in tests) {
                      utf8_to_ucs2.toString('ucs2'));
 }
 
-assert.throws(
+common.expectsError(
   () => buffer.transcode(null, 'utf8', 'ascii'),
-  /^TypeError: "source" argument must be a Buffer or Uint8Array$/
+  {
+    type: TypeError,
+    code: 'ERR_INVALID_ARG_TYPE',
+    message: 'The "source" argument must be one of type Buffer ' +
+             'or Uint8Array. Received type null'
+  }
 );
 
 assert.throws(