Skip to content

Commit

Permalink
Replace FormBuilder with FormBuilderInterface
Browse files Browse the repository at this point in the history
  • Loading branch information
EmmanuelVella committed Mar 12, 2015
1 parent 1ec5109 commit 187b3d2
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 48 deletions.
6 changes: 3 additions & 3 deletions Admin/Admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
use Sonata\CoreBundle\Model\Metadata;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\FormBuilder;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\PropertyAccess\PropertyPath;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\Validator\ValidatorInterface;
Expand Down Expand Up @@ -1322,11 +1322,11 @@ public function getFormBuilder()
* This method is being called by the main admin class and the child class,
* the getFormBuilder is only call by the main admin class
*
* @param \Symfony\Component\Form\FormBuilder $formBuilder
* @param \Symfony\Component\Form\FormBuilderInterface $formBuilder
*
* @return void
*/
public function defineFormBuilder(FormBuilder $formBuilder)
public function defineFormBuilder(FormBuilderInterface $formBuilder)
{
$mapper = new FormMapper($this->getFormContractor(), $formBuilder, $this);

Expand Down
10 changes: 5 additions & 5 deletions Admin/AdminHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

use Doctrine\Common\Inflector\Inflector;
use Doctrine\Common\Util\ClassUtils;
use Symfony\Component\Form\FormBuilder;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormView;
use Sonata\AdminBundle\Exception\NoValueException;
use Sonata\AdminBundle\Util\FormViewIterator;
Expand All @@ -33,12 +33,12 @@ public function __construct(Pool $pool)
/**
* @throws \RuntimeException
*
* @param \Symfony\Component\Form\FormBuilder $formBuilder
* @param string $elementId
* @param \Symfony\Component\Form\FormBuilderInterface $formBuilder
* @param string $elementId
*
* @return \Symfony\Component\Form\FormBuilder
* @return \Symfony\Component\Form\FormBuilderInterface
*/
public function getChildFormBuilder(FormBuilder $formBuilder, $elementId)
public function getChildFormBuilder(FormBuilderInterface $formBuilder, $elementId)
{
foreach (new FormBuilderIterator($formBuilder) as $name => $formBuilder) {
if ($name == $elementId) {
Expand Down
2 changes: 1 addition & 1 deletion Admin/AdminInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public function getManagerType();
public function createQuery($context = 'list');

/**
* @return \Symfony\Component\Form\FormBuilder the form builder
* @return \Symfony\Component\Form\FormBuilderInterface the form builder
*/
public function getFormBuilder();

Expand Down
6 changes: 3 additions & 3 deletions Datagrid/Datagrid.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
use Sonata\AdminBundle\Filter\FilterInterface;
use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Symfony\Component\Form\FormBuilder;
use Symfony\Component\Form\Exception\UnexpectedTypeException;
use Symfony\Component\Form\CallbackTransformer;
use Symfony\Component\Form\FormBuilderInterface;

class Datagrid implements DatagridInterface
{
Expand Down Expand Up @@ -47,10 +47,10 @@ class Datagrid implements DatagridInterface
* @param ProxyQueryInterface $query
* @param FieldDescriptionCollection $columns
* @param PagerInterface $pager
* @param FormBuilder $formBuilder
* @param FormBuilderInterface $formBuilder
* @param array $values
*/
public function __construct(ProxyQueryInterface $query, FieldDescriptionCollection $columns, PagerInterface $pager, FormBuilder $formBuilder, array $values = array())
public function __construct(ProxyQueryInterface $query, FieldDescriptionCollection $columns, PagerInterface $pager, FormBuilderInterface $formBuilder, array $values = array())
{
$this->pager = $pager;
$this->query = $query;
Expand Down
8 changes: 4 additions & 4 deletions Form/FormMapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

use Sonata\AdminBundle\Builder\FormContractorInterface;
use Sonata\AdminBundle\Admin\AdminInterface;
use Symfony\Component\Form\FormBuilder;
use Sonata\AdminBundle\Mapper\BaseGroupedMapper;
use Symfony\Component\Form\FormBuilderInterface;

/**
* This class is use to simulate the Form API
Expand All @@ -25,13 +25,13 @@ class FormMapper extends BaseGroupedMapper

/**
* @param \Sonata\AdminBundle\Builder\FormContractorInterface $formContractor
* @param \Symfony\Component\Form\FormBuilder $formBuilder
* @param \Symfony\Component\Form\FormBuilderInterface $formBuilder
* @param \Sonata\AdminBundle\Admin\AdminInterface $admin
*/
public function __construct(FormContractorInterface $formContractor, FormBuilder $formBuilder, AdminInterface $admin)
public function __construct(FormContractorInterface $formContractor, FormBuilderInterface $formBuilder, AdminInterface $admin)
{
parent::__construct($formContractor, $admin);
$this->formBuilder = $formBuilder;
$this->formBuilder = $formBuilder;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion Tests/Admin/AdminTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,7 @@ private function createTagAdmin(Post $post)

$postAdmin->expects($this->any())->method('getObject')->will($this->returnValue($post));

$formBuilder = $this->getMockForAbstractClass('Sonata\AdminBundle\Tests\Form\Builder\FormBuilder');
$formBuilder = $this->getMock('Symfony\Component\Form\FormBuilderInterface');
$formBuilder->expects($this->any())->method('getForm')->will($this->returnValue(null));

$tagAdmin = $this->getMockBuilder('Sonata\AdminBundle\Tests\Fixtures\Admin\TagAdmin')
Expand Down
25 changes: 0 additions & 25 deletions Tests/Form/Builder/FormBuilder.php

This file was deleted.

12 changes: 6 additions & 6 deletions Util/FormBuilderIterator.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Sonata\AdminBundle\Util;

use Symfony\Component\Form\FormBuilder;
use Symfony\Component\Form\FormBuilderInterface;

class FormBuilderIterator extends \RecursiveArrayIterator
{
Expand All @@ -25,10 +25,10 @@ class FormBuilderIterator extends \RecursiveArrayIterator
protected $iterator;

/**
* @param \Symfony\Component\Form\FormBuilder $formBuilder
* @param bool $prefix
* @param \Symfony\Component\Form\FormBuilderInterface $formBuilder
* @param bool $prefix
*/
public function __construct(FormBuilder $formBuilder, $prefix = false)
public function __construct(FormBuilderInterface $formBuilder, $prefix = false)
{
$this->formBuilder = $formBuilder;
$this->prefix = $prefix ? $prefix : $formBuilder->getName();
Expand All @@ -38,11 +38,11 @@ public function __construct(FormBuilder $formBuilder, $prefix = false)
/**
* @static
*
* @param \Symfony\Component\Form\FormBuilder $formBuilder
* @param \Symfony\Component\Form\FormBuilderInterface $formBuilder
*
* @return array
*/
private static function getKeys(FormBuilder $formBuilder)
private static function getKeys(FormBuilderInterface $formBuilder)
{
if (!self::$reflection) {
self::$reflection = new \ReflectionProperty(get_class($formBuilder), 'children');
Expand Down

0 comments on commit 187b3d2

Please sign in to comment.