Skip to content

Commit

Permalink
firewire: nosy: Replace timeval with timespec64
Browse files Browse the repository at this point in the history
'struct timeval' uses a 32 bit field for its 'seconds' value which
will overflow in year 2038 and beyond. This patch replaces the use
of timeval in nosy.c with timespec64 which doesn't suffer from y2038
issue. The code is correct as is - since it is only using the
microseconds portion of timeval. However, this patch does the
replacement as part of a larger effort to remove all instances of
'struct timeval' from the kernel (that would help identify cases
where the code is actually broken).

Signed-off-by: Tina Ruchandani <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Signed-off-by: Stefan Richter <[email protected]>
  • Loading branch information
Tinabr7 authored and Stefan Richter committed Mar 22, 2016
1 parent e38e5ce commit 384fbb9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/firewire/nosy.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,14 +446,16 @@ static void
bus_reset_irq_handler(struct pcilynx *lynx)
{
struct client *client;
struct timeval tv;
struct timespec64 ts64;
u32 timestamp;

do_gettimeofday(&tv);
ktime_get_real_ts64(&ts64);
timestamp = ts64.tv_nsec / NSEC_PER_USEC;

spin_lock(&lynx->client_list_lock);

list_for_each_entry(client, &lynx->client_list, link)
packet_buffer_put(&client->buffer, &tv.tv_usec, 4);
packet_buffer_put(&client->buffer, &timestamp, 4);

spin_unlock(&lynx->client_list_lock);
}
Expand Down

0 comments on commit 384fbb9

Please sign in to comment.