Apply charset option to search queries consistently. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charsets different from UTF-8 or US-ASCII need to be converted to UTF-7. If this conversion is not done, characters not belonging to US-ASCII will make the request fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In search queries, when using a charset different from US-ASCII in a session with no UTF-8 capability, characters not belonging to the US-ASCII charset need to be converted to UTF-7. If this conversion is not done, characters not belonging to US-ASCII will make the request fail.
For instance, without this patch the search query "Areté" only will succeed using a UTF-8 charset inside a session with UTF-8 capability. It will fail if ssn->uft8 is set to false but the query is written in UTF-8.