[DBUTILS-137] Inefficient allocation of Maps in

org.apache.commons.dbutils.BasicRowProcessor.toMap(ResultSet).
leiyuxin · Dec 24, 2017 · 001e87d · 001e87d
1 parent 084f286
commit 001e87d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -48,6 +48,9 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="update" issue="DBUTILS-135" due-to="hdevalke">
         BeanProcessor is not thread safe since [DBUTILS-124].
       </action>
+      <action dev="ggregory" type="update" issue="DBUTILS-137" due-to="Gary Gregory">
+        Inefficient allocation of Maps in org.apache.commons.dbutils.BasicRowProcessor.toMap(ResultSet).
+      </action>
     </release>
 
     <release version="1.7" date="2017-07-20" description="Bug fixes and separate column &amp; property handlers using SPI">

diff --git a/src/main/java/org/apache/commons/dbutils/BasicRowProcessor.java b/src/main/java/org/apache/commons/dbutils/BasicRowProcessor.java
@@ -157,9 +157,9 @@ public <T> List<T> toBeanList(ResultSet rs, Class<? extends T> type) throws SQLE
      */
     @Override
     public Map<String, Object> toMap(ResultSet rs) throws SQLException {
-        Map<String, Object> result = new CaseInsensitiveHashMap();
         ResultSetMetaData rsmd = rs.getMetaData();
         int cols = rsmd.getColumnCount();
+        Map<String, Object> result = new CaseInsensitiveHashMap(cols);
 
         for (int i = 1; i <= cols; i++) {
             String columnName = rsmd.getColumnLabel(i);
@@ -188,6 +188,11 @@ public Map<String, Object> toMap(ResultSet rs) throws SQLException {
      * </pre>
      */
     private static class CaseInsensitiveHashMap extends LinkedHashMap<String, Object> {
+
+        private CaseInsensitiveHashMap(int initialCapacity) {
+            super(initialCapacity);
+        }
+
         /**
          * The internal mapping from lowercase keys to the real keys.
          *