Throw error explicitly on param value not in range (apache#3950)

leizhiyuan · Apr 1, 2019 · daa0a18 · daa0a18
1 parent e36ae70
commit daa0a18
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarSourceBuilder.java b/...flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarSourceBuilder.java
@@ -158,8 +158,9 @@ public PulsarSourceBuilder<T> subscriptionName(String subscriptionName) {
     public PulsarSourceBuilder<T> acknowledgementBatchSize(long size) {
         if (size > 0 && size <= MAX_ACKNOWLEDGEMENT_BATCH_SIZE) {
             acknowledgementBatchSize = size;
+            return this;
         }
-        return this;
+        throw new IllegalArgumentException("acknowledgementBatchSize can only take values > 0 and <= " + MAX_ACKNOWLEDGEMENT_BATCH_SIZE);
     }
 
     public SourceFunction<T> build() {