Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use six.add_metaclass to support py37 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use six.add_metaclass to support py37 #8

wants to merge 1 commit into from

Conversation

stj
Copy link

@stj stj commented Jan 8, 2019

six.with_metaclass fails under python 3.7. Six has another
metaclass-constructor that does not suffer the same failure.

https://bitbucket.org/gutworth/six/pull-requests/12/add-patch_with_metaclass-which-provides-a/diff

`six.with_metaclass` fails under python 3.7. Six has another
metaclass-constructor that does not suffer the same failure.

https://bitbucket.org/gutworth/six/pull-requests/12/add-patch_with_metaclass-which-provides-a/diff
@henriklynggaard
Copy link

would this solve my issue? #9

@stj
Copy link
Author

stj commented Jan 25, 2019

Yes, this or #7 solves the issue. Both PRs are from me.

@ferndot
Copy link

ferndot commented Feb 8, 2019

Somebody please merge this

@pdecol
Copy link

pdecol commented Jul 8, 2019

@todofixthis, any updates? Can you reach someone who has permissions to merge this? It would be great to get this done and have it Python 3.7 compatible.

@Panos512
Copy link

Panos512 commented Aug 4, 2019

Hello, Could someone merge this, please?

@infothrill
Copy link

+1

@todofixthis
Copy link
Contributor

Hey @Panos512 @infothrill I apologise that there's been radio silence on this one. I no longer work at EFL Global (now LenddoEFL); I'll see if I can get in touch with someone though.

@todofixthis
Copy link
Contributor

Hi @Panos512 @infothrill I'm really sorry that this is taking so long. I have gotten in touch with someone at LenddoEFL, and they are working on it.

If we don't have resolution within the next couple of days, I will fork this project and release it under a different name.

@todofixthis
Copy link
Contributor

Hey @Panos512 @infothrill I apologise that it has taken so long to address this.

I have forked the project, removed support for Python 2, added support for Python 3.7 and 3.8 as well as pypy3.

The new project is called phx-class-registry, and I will be maintaining this project personally from now on.

@infothrill
Copy link

awesome. thank you

@Panos512
Copy link

Perfect! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants