ofp-util: Use OFPGMFC_OUT_OF_BUCKETS for indirect groups with !=1 buc…

…kets. OpenFlow 1.3 says: If a switch cannot add the incoming group entry due to restrictions (hardware or otherwise) limiting the number of group buckets, it must refuse to add the group entry and must send an ofp_error_msg with OFPET_GROUP_MOD_FAILED type and OFPGMFC_OUT_OF_BUCKETS code. This indicates that OFPGMFC_OUT_OF_BUCKETS is appropriate for an indirect group with the wrong number of buckets, but OVS was using a different error. This fixes the problem. ONF-JIRA: EXT-546 Reported-by: Mrinmoy Das <[email protected]> Signed-off-by: Ben Pfaff <[email protected]> Acked-by: Justin Pettit <[email protected]>
leonshaw · May 8, 2015 · 36be51c · 36be51c
1 parent 3afcde4
commit 36be51c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/AUTHORS b/AUTHORS
@@ -303,6 +303,7 @@ Mike Bursell            [email protected]
 Mike Kruze              [email protected]
 Min Chen                [email protected]
 Mikael Doverhag         [email protected]
+Mrinmoy Das             [email protected]
 Nagi Reddy Jonnala      [email protected]
 Niels van Adrichem      [email protected]
 Niklas Andersson        [email protected]

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
@@ -8375,7 +8375,7 @@ ofputil_decode_group_mod(const struct ofp_header *oh,
     switch (gm->type) {
     case OFPGT11_INDIRECT:
         if (!list_is_singleton(&gm->buckets)) {
-            return OFPERR_OFPGMFC_INVALID_GROUP;
+            return OFPERR_OFPGMFC_OUT_OF_BUCKETS;
         }
         break;
     case OFPGT11_ALL: