netdev-dpdk: Do not flush tx queue which is shared among CPUs since i…

…t is always flushed When tx queue is shared among CPUS,the pkts always be flush in 'netdev_dpdk_eth_send'. So it is unnecessarily for flushing in netdev_dpdk_rxq_recv Otherwise tx will be accessed without locking. Signed-off-by: Wei li <[email protected]> Acked-by: Daniele Di Proietto <[email protected]> Acked-by: Pravin B Shelar <[email protected]>
leonshaw · Jun 25, 2015 · 4062928 · 4062928
1 parent 22b4ccf
commit 4062928
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
@@ -928,8 +928,11 @@ netdev_dpdk_rxq_recv(struct netdev_rxq *rxq_, struct dp_packet **packets,
     int nb_rx;
 
     /* There is only one tx queue for this core.  Do not flush other
-     * queueus. */
-    if (rxq_->queue_id == rte_lcore_id()) {
+     * queues.
+     * Do not flush tx queue which is shared among CPUs
+     * since it is always flushed */
+    if (rxq_->queue_id == rte_lcore_id() &&
+        OVS_LIKELY(!dev->txq_needs_locking)) {
         dpdk_queue_flush(dev, rxq_->queue_id);
     }