Skip to content

Commit

Permalink
datapath-windows: Solved BSOD when handling flows
Browse files Browse the repository at this point in the history
OvsPrepareFlow() returns an error only when the new flow allocation
fails. In this case HandleFlowPut() should return error without trying
to free the flow, thus avoiding the BSOD.

Signed-off-by: Sorin Vinturis <[email protected]>
Reported-by: Sorin Vinturis <[email protected]>
Reported-at: openvswitch/ovs-issues#91
Acked-by: Alin Gabriel Serdean <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
svinturis authored and blp committed Jul 1, 2015
1 parent b21f6c9 commit cddc232
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion datapath-windows/ovsext/Flow.c
Original file line number Diff line number Diff line change
Expand Up @@ -2163,7 +2163,6 @@ HandleFlowPut(OvsFlowPut *put,

status = OvsPrepareFlow(&KernelFlow, put, hash);
if (status != STATUS_SUCCESS) {
FreeFlow(KernelFlow);
return STATUS_UNSUCCESSFUL;
}

Expand Down

0 comments on commit cddc232

Please sign in to comment.