Skip to content

Commit

Permalink
Kill all uses of t.c.collections.OrderedDict. (pantsbuild#8003)
Browse files Browse the repository at this point in the history
We can rely on the stdlib instead now.
  • Loading branch information
jsirois authored Jul 3, 2019
1 parent 244e94d commit d66d8ba
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion tests/python/pants_test/backend/python/tasks/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ python_tests(
sources = ['test_build_local_python_distributions.py'],
dependencies = [
'3rdparty/python:pex',
'3rdparty/python/twitter/commons:twitter.common.collections',
'src/python/pants/backend/python:python_requirement',
'src/python/pants/backend/python/targets',
'tests/python/pants_test/backend/python/tasks/util',
Expand Down
5 changes: 0 additions & 5 deletions tests/python/pants_test/backend/python/tasks/native/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
python_tests(
sources=globs('test_*.py', exclude=[globs('*_integration.py')]),
dependencies=[
'3rdparty/python/twitter/commons:twitter.common.collections',
'3rdparty/python/twitter/commons:twitter.common.dirutil',
'3rdparty/python:coverage',
'3rdparty/python:pex',
'src/python/pants/backend/native',
'src/python/pants/backend/python/subsystems',
'src/python/pants/backend/python/targets',
Expand Down Expand Up @@ -39,7 +35,6 @@ python_tests(
name='integration',
sources=globs('*_integration.py'),
dependencies=[
'3rdparty/python/twitter/commons:twitter.common.collections',
'src/python/pants/backend/native',
'src/python/pants/backend/native/targets',
'src/python/pants/backend/python:plugin',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2018 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from twitter.common.collections import OrderedDict
from collections import OrderedDict

from pants.backend.native.targets.native_artifact import NativeArtifact
from pants.backend.native.targets.native_library import CLibrary, CppLibrary
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Licensed under the Apache License, Version 2.0 (see LICENSE).

import re
from collections import OrderedDict

import pex.resolver
from twitter.common.collections import OrderedDict

from pants.backend.python.python_requirement import PythonRequirement
from pants.backend.python.targets.python_distribution import PythonDistribution
Expand Down

0 comments on commit d66d8ba

Please sign in to comment.