Skip to content

Commit

Permalink
[SPARK-17056][CORE] Fix a wrong assert regarding unroll memory in Mem…
Browse files Browse the repository at this point in the history
…oryStore

## What changes were proposed in this pull request?

There is an assert in MemoryStore's putIteratorAsValues method which is used to check if unroll memory is not released too much. This assert looks wrong.

## How was this patch tested?

Jenkins tests.

Author: Liang-Chi Hsieh <[email protected]>

Closes apache#14642 from viirya/fix-unroll-memory.
  • Loading branch information
viirya authored and JoshRosen committed Sep 27, 2016
1 parent 2f84a68 commit e7bce9e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ private[spark] class MemoryStore(
blockId, Utils.bytesToString(size), Utils.bytesToString(maxMemory - blocksMemoryUsed)))
Right(size)
} else {
assert(currentUnrollMemoryForThisTask >= currentUnrollMemoryForThisTask,
assert(currentUnrollMemoryForThisTask >= unrollMemoryUsedByThisBlock,
"released too much unroll memory")
Left(new PartiallyUnrolledIterator(
this,
Expand Down

0 comments on commit e7bce9e

Please sign in to comment.