Move deferred utils to their own file (shipshapecode#315)

jest.config.js

@@ -7,7 +7,7 @@ module.exports = {
 
   // An array of glob patterns indicating a set of files for which coverage information should be collected
   collectCoverageFrom: [
-    'src/js/*.js'
+    'src/js/**/*.js'
   ],
 
   // The directory where Jest should output its coverage files

src/js/abutment.js

@@ -1,7 +1,8 @@
 import TetherBase from './utils';
 import { updateClasses } from './utils/classes';
+import { defer } from './utils/deferred';
 
-const { getBounds, defer } = TetherBase.Utils;
+const { getBounds } = TetherBase.Utils;
 
 TetherBase.modules.push({
   position({ top, left }) {

src/js/constraint.js

@@ -1,10 +1,10 @@
 import TetherBase from './utils';
 import { updateClasses } from './utils/classes';
+import { defer } from './utils/deferred';
 
 const {
   getBounds,
-  extend,
-  defer
+  extend
 } = TetherBase.Utils;
 
 const BOUNDS_FORMAT = ['left', 'top', 'right', 'bottom'];

src/js/tether.js

@@ -7,6 +7,7 @@ import '../css/tether-theme-basic.scss';
 import { Evented } from './evented';
 import TetherBase from './utils';
 import { addClass, removeClass, updateClasses } from './utils/classes';
+import { defer, flush } from './utils/deferred';
 import './constraint';
 import './abutment';
 import './shift';
@@ -16,8 +17,6 @@ const {
   getBounds,
   getOffsetParent,
   extend,
-  defer,
-  flush,
   getScrollBarSize,
   removeUtilElements
 } = TetherBase.Utils;

src/js/utils.js

@@ -1,3 +1,5 @@
+import { defer } from './utils/deferred';
+
 let TetherBase;
 if (typeof TetherBase === 'undefined') {
   TetherBase = { modules: [] };
@@ -221,41 +223,11 @@ function extend(out = {}) {
   return out;
 }
 
-function getClassName(el) {
-  // Can't use just SVGAnimatedString here since nodes within a Frame in IE have
-  // completely separately SVGAnimatedString base classes
-  if (el.className instanceof el.ownerDocument.defaultView.SVGAnimatedString) {
-    return el.className.baseVal;
-  }
-  return el.className;
-}
-
-function setClassName(el, className) {
-  el.setAttribute('class', className);
-}
-
-const deferred = [];
-
-const defer = (fn) => {
-  deferred.push(fn);
-};
-
-const flush = () => {
-  let fn;
-  // eslint-disable-next-line
-  while (fn = deferred.pop()) {
-    fn();
-  }
-};
-
 TetherBase.Utils = {
-  getActualBoundingClientRect,
   getScrollParents,
   getBounds,
   getOffsetParent,
   extend,
-  defer,
-  flush,
   uniqueId,
   getScrollBarSize,
   removeUtilElements

src/js/utils/deferred.js

@@ -0,0 +1,13 @@
+const deferred = [];
+
+export function defer(fn) {
+  deferred.push(fn);
+}
+
+export function flush() {
+  let fn;
+  // eslint-disable-next-line
+  while (fn = deferred.pop()) {
+    fn();
+  }
+}

test/unit/deferred.spec.js

@@ -0,0 +1,18 @@
+import { defer, flush } from '../../src/js/utils/deferred';
+import { stub } from 'sinon';
+
+describe('deferred', () => {
+  describe('defer/flush', () => {
+    it('calls deferred functions when flush is called', () => {
+      const stub1 = stub();
+      const stub2 = stub();
+      defer(stub1);
+      defer(stub2);
+      expect(stub1.called).toBe(false);
+      expect(stub2.called).toBe(false);
+      flush();
+      expect(stub1.called).toBe(true);
+      expect(stub2.called).toBe(true);
+    });
+  });
+});