catch by reference to avoid slicing

this suppress some cppcheck warning
levi-2020 · Jan 20, 2015 · 4dc3210 · 4dc3210
1 parent b61e088
commit 4dc3210
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/common/include/pcl/impl/pcl_base.hpp b/common/include/pcl/impl/pcl_base.hpp
@@ -151,7 +151,7 @@ pcl::PCLBase<PointT>::initCompute ()
     {
       indices_->resize (input_->points.size ());
     }
-    catch (std::bad_alloc)
+    catch (const std::bad_alloc&)
     {
       PCL_ERROR ("[initCompute] Failed to allocate %lu indices.\n", input_->points.size ());
     }

diff --git a/common/src/pcl_base.cpp b/common/src/pcl_base.cpp
@@ -140,7 +140,7 @@ pcl::PCLBase<pcl::PCLPointCloud2>::initCompute ()
     {
       indices_->resize (input_->width * input_->height);
     }
-    catch (std::bad_alloc)
+    catch (const std::bad_alloc&)
     {
       PCL_ERROR ("[initCompute] Failed to allocate %lu indices.\n", (input_->width * input_->height));
     }

diff --git a/doc/tutorials/content/sources/vfh_recognition/build_tree.cpp b/doc/tutorials/content/sources/vfh_recognition/build_tree.cpp
@@ -35,7 +35,7 @@ loadHist (const boost::filesystem::path &path, vfh_model &vfh)
     if ((int)cloud.width * cloud.height != 1)
       return (false);
   }
-  catch (pcl::InvalidConversionException e)
+  catch (const pcl::InvalidConversionException&)
   {
     return (false);
   }

diff --git a/doc/tutorials/content/sources/vfh_recognition/nearest_neighbors.cpp b/doc/tutorials/content/sources/vfh_recognition/nearest_neighbors.cpp
@@ -38,7 +38,7 @@ loadHist (const boost::filesystem::path &path, vfh_model &vfh)
     if ((int)cloud.width * cloud.height != 1)
       return (false);
   }
-  catch (pcl::InvalidConversionException e)
+  catch (const pcl::InvalidConversionException&)
   {
     return (false);
   }

diff --git a/io/src/hdl_grabber.cpp b/io/src/hdl_grabber.cpp
@@ -497,7 +497,7 @@ pcl::HDLGrabber::start ()
       try {
 		  hdl_read_socket_ = new udp::socket (hdl_read_socket_service_, udp_listener_endpoint_);
 	  }
-	  catch (std::exception bind) {
+	  catch (const std::exception& bind) {
 		  delete hdl_read_socket_;
 		  hdl_read_socket_ = new udp::socket (hdl_read_socket_service_, udp::endpoint(boost::asio::ip::address_v4::any(), udp_listener_endpoint_.port()));
 	  }

diff --git a/test/io/test_io.cpp b/test/io/test_io.cpp
@@ -1148,7 +1148,7 @@ TEST (PCL, Locale)
       std::locale::global (std::locale ("de_DE.UTF-8"));
 #endif
     }
-    catch (std::runtime_error e)
+    catch (const std::runtime_error&)
     {
       PCL_WARN ("Failed to set locale, skipping test.\n");
     }
@@ -1164,7 +1164,7 @@ TEST (PCL, Locale)
       std::locale::global (std::locale ("en_US.UTF-8"));
 #endif
     }
-    catch (std::runtime_error e)
+    catch (const std::runtime_error&)
     {
       PCL_WARN ("Failed to set locale, skipping test.\n");
     }
@@ -1186,7 +1186,7 @@ TEST (PCL, Locale)
       ASSERT_FLOAT_EQ (cloud2.points[i].z, cloud.points[i].z);
     }
   }
-  catch(std::exception& e)
+  catch (const std::exception&)
   {
   }
 #endif

diff --git a/tools/pcd2png.cpp b/tools/pcd2png.cpp
@@ -155,7 +155,7 @@ parseScaleOption (int argc, char** argv, T& pcie)
       pcie.setScalingMethod(pcie.SCALING_FIXED_FACTOR);
       pcie.setScalingFactor(factor);
     }
-    catch (boost::bad_lexical_cast)
+    catch (const boost::bad_lexical_cast&)
     {
       print_error ("The value of --scale option should be \"no\", \"auto\", or a floating point number.\n");
       return false;