Use { index, value } instead of [index, value] for all.

See kriskowal#333 (comment).
levishi · Aug 5, 2013 · 97c9170 · 97c9170
1 parent ca5297a
commit 97c9170
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/q.js b/q.js
@@ -1515,7 +1515,7 @@ function all(promises) {
                     },
                     deferred.reject,
                     function (progress) {
-                        deferred.notify([index, progress]);
+                        deferred.notify({ index: index, value: progress });
                     }
                 );
             }

diff --git a/spec/q-spec.js b/spec/q-spec.js
@@ -1137,7 +1137,7 @@ describe("all", function () {
         });
     });
 
-    it("sends [index, value] progress updates", function () {
+    it("sends { index, value } progress updates", function () {
         var deferred1 = Q.defer();
         var deferred2 = Q.defer();
 
@@ -1157,7 +1157,11 @@ describe("all", function () {
 
         return Q.all([deferred1.promise, deferred2.promise]).then(
             function () {
-                expect(progressValues).toEqual([[0, "a"], [1, "b"], [0, "c"]]);
+                expect(progressValues).toEqual([
+                    { index: 0, value: "a" },
+                    { index: 1, value: "b" },
+                    { index: 0, value: "c" }
+                ]);
             },
             undefined,
             function (progressValue) {