Skip to content

Commit

Permalink
fix: potential fix for rendering issues on lists with big amount of i…
Browse files Browse the repository at this point in the history
…tems (#862jmqj2v)
  • Loading branch information
dziudek committed Apr 15, 2023
1 parent 413b854 commit 9b2e5cc
Show file tree
Hide file tree
Showing 12 changed files with 23 additions and 18 deletions.
2 changes: 1 addition & 1 deletion app/back-end/builddata.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"0.42.0","build":16231}
{"version":"0.42.0","build":16233}
5 changes: 3 additions & 2 deletions app/src/components/Authors.vue
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,15 @@
<collection-row
v-for="(item, index) in items"
slot="content"
:key="index"
:key="'collection-row-' + index"
:cssClasses="item.id === 1 ? 'is-main-author' : ''">
<collection-cell>
<checkbox
v-if="item.id !== 1"
:value="item.id"
:checked="isChecked(item.id)"
:onClick="toggleSelection" />
:onClick="toggleSelection"
:key="'collection-row-checkbox-' + index" />

<span
v-if="item.id === 1"
Expand Down
5 changes: 3 additions & 2 deletions app/src/components/Backups.vue
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,14 @@
<collection-row
v-for="(item, index) in items"
slot="content"
:key="index">
:key="'collection-row-' + index">
<collection-cell>
<checkbox
:id="item.name"
:value="item.id"
:checked="isChecked(item.id)"
:onClick="toggleSelection" />
:onClick="toggleSelection"
:key="'collection-row-checkbox-' + index" />
</collection-cell>

<collection-cell>
Expand Down
5 changes: 3 additions & 2 deletions app/src/components/FileManager.vue
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,13 @@
<collection-row
v-for="(item, index) in filteredFiles"
slot="content"
:key="index">
:key="'collection-row-' + index">
<collection-cell>
<checkbox
:value="item.name"
:checked="isChecked(index)"
:onClick="toggleSelection.bind(this, index)" />
:onClick="toggleSelection.bind(this, index)"
:key="'collection-row-checkbox-' + index" />
</collection-cell>

<collection-cell
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/LanguagesList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<language-item
v-for="(language, index) in languages"
:languageData="language"
:key="index" />
:key="'language-item-' + index" />

<overlay
v-if="languageIsOver"
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/PluginsList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<plugin-item
v-for="(plugin, index) in plugins"
:pluginData="plugin"
:key="index" />
:key="'plugin-item-' + index" />

<overlay
v-if="pluginIsOver"
Expand Down
5 changes: 3 additions & 2 deletions app/src/components/Posts.vue
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,13 @@
v-for="(item, index) in items"
slot="content"
:data-is-draft="item.isDraft"
:key="index">
:key="'collection-row-' + index">
<collection-cell>
<checkbox
:value="item.id"
:checked="isChecked(item.id)"
:onClick="toggleSelection" />
:onClick="toggleSelection"
:key="'collection-row-checkbox-' + index" />
</collection-cell>

<collection-cell
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/SidebarMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<ul class="sidebar-menu">
<li
v-for="(item, index) in items"
:key="index"
:key="'sidebar-item-' + index"
:class="{ 'sidebar-menu-item': true, 'is-active': item.icon === activeMenuItem }"
@click="setActiveMenuItem(item.icon)">
<router-link :to="item.url">
Expand Down
5 changes: 3 additions & 2 deletions app/src/components/Tags.vue
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,13 @@
<collection-row
v-for="(item, index) in items"
slot="content"
:key="index">
:key="'collection-row-' + index">
<collection-cell>
<checkbox
:value="item.id"
:checked="isChecked(item.id)"
:onClick="toggleSelection" />
:onClick="toggleSelection"
:key="'collection-row-checkbox-' + index" />
</collection-cell>

<collection-cell>
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/ThemesList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<theme-item
v-for="(theme, index) in themes"
:themeData="theme"
:key="index" />
:key="'theme-item-' + index" />

<overlay
v-if="themeIsOver"
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/WPImport.vue
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
:label="cpt"
:labelSeparated="false"
:noLabelSpace="true"
:key="index"
:key="'custom-post-type-item-' + index"
spacing="small">
<switcher
slot="field"
Expand Down
4 changes: 2 additions & 2 deletions app/src/components/basic-elements/Tabs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<ul>
<li
v-for="(item, index) in items"
:key="index"
:key="'tab-item-' + index"
:class="{ 'active': item === activeItem}"
@click="toggle(item)">
{{ item }}
Expand All @@ -20,7 +20,7 @@
<div class="content">
<div
v-for="(item, index) in items"
:key="index"
:key="'tab-item-content-' + index"
:class="{ 'tab': true, 'active': item === activeItem}">
<slot :name="'tab-' + index"></slot>
</div>
Expand Down

0 comments on commit 9b2e5cc

Please sign in to comment.