Skip to content

Commit

Permalink
Merge pull request isocpp#877 from cubbimew/travis-fixes-3-30-17
Browse files Browse the repository at this point in the history
travis fixes
  • Loading branch information
cubbimew authored Apr 1, 2017
2 parents 65aa60f + 83566ba commit a516bfe
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
12 changes: 8 additions & 4 deletions CppCoreGuidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -1868,9 +1868,13 @@ Having many arguments opens opportunities for confusion. Passing lots of argumen

The two most common reasons why functions have too many parameters are:

1. *Missing an abstraction.* There is an abstraction missing, so that a compound value is being passed as individual elements instead of as a single object that enforces an invariant. This not only expands the parameter list, but it leads to errors because the component values are no longer protected by an enforced invariant.
1. *Missing an abstraction.* There is an abstraction missing, so that a compound value is being
passed as individual elements instead of as a single object that enforces an invariant.
This not only expands the parameter list, but it leads to errors because the component values
are no longer protected by an enforced invariant.

2. *Violating "one function, one responsibility."* The function is trying to do more than one job and should probably be refactored.
2. *Violating "one function, one responsibility."* The function is trying to do more than one
job and should probably be refactored.

##### Example

Expand Down Expand Up @@ -17755,7 +17759,7 @@ Pointers should only refer to single objects, and pointer arithmetic is fragile

int n = a[0]; // OK

span<int> q = a.subspan(1); // OK
span<int> q = a.subspan(1); // OK

if (a.length() < 6) return;

Expand Down Expand Up @@ -17836,7 +17840,7 @@ Dynamic accesses into arrays are difficult for both tools and humans to validate
void f1a()
{
int arr[COUNT];
span<int,COUNT> av = arr;
span<int, COUNT> av = arr;
int i = 0;
for (auto& e : av)
e = i++;
Expand Down
1 change: 1 addition & 0 deletions scripts/hunspell/isocpp.dic
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,7 @@ UB
unaliased
uncompromised
undetached
unencapsulated
unenforceable
uninit
uniqueptrparam
Expand Down

0 comments on commit a516bfe

Please sign in to comment.