Changed the return type of YGResolveValueMargin to YGFloatOptional

Summary: Changed the return type of YGResolveValueMargin to YGFloatOptional Reviewed By: emilsjolander Differential Revision: D7304090 fbshipit-source-id: cbec03a9367cf34976d083ad475d4da0b736e6d2
levyking888 · Apr 3, 2018 · 4b760fa · 4b760fa
1 parent 5730be0
commit 4b760fa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/yoga/Utils.h b/yoga/Utils.h
@@ -136,8 +136,9 @@ inline YGFlexDirection YGResolveFlexDirection(
   return flexDirection;
 }
 
-static inline float YGResolveValueMargin(
+static inline YGFloatOptional YGResolveValueMargin(
     const YGValue value,
     const float ownerSize) {
-  return value.unit == YGUnitAuto ? 0 : YGUnwrapFloatOptional(YGResolveValue(value, ownerSize));
+  return value.unit == YGUnitAuto ? YGFloatOptional(0)
+                                  : YGResolveValue(value, ownerSize);
 }
diff --git a/yoga/YGNode.cpp b/yoga/YGNode.cpp
@@ -144,25 +144,27 @@ float YGNode::getLeadingMargin(
     const float widthSize) const {
   if (YGFlexDirectionIsRow(axis) &&
       style_.margin[YGEdgeStart].unit != YGUnitUndefined) {
-    return YGResolveValueMargin(style_.margin[YGEdgeStart], widthSize);
+    return YGUnwrapFloatOptional(
+        YGResolveValueMargin(style_.margin[YGEdgeStart], widthSize));
   }
 
-  return YGResolveValueMargin(
+  return YGUnwrapFloatOptional(YGResolveValueMargin(
       *YGComputedEdgeValue(style_.margin, leading[axis], &YGValueZero),
-      widthSize);
+      widthSize));
 }
 
 float YGNode::getTrailingMargin(
     const YGFlexDirection axis,
     const float widthSize) const {
   if (YGFlexDirectionIsRow(axis) &&
       style_.margin[YGEdgeEnd].unit != YGUnitUndefined) {
-    return YGResolveValueMargin(style_.margin[YGEdgeEnd], widthSize);
+    return YGUnwrapFloatOptional(
+        YGResolveValueMargin(style_.margin[YGEdgeEnd], widthSize));
   }
 
-  return YGResolveValueMargin(
+  return YGUnwrapFloatOptional(YGResolveValueMargin(
       *YGComputedEdgeValue(style_.margin, trailing[axis], &YGValueZero),
-      widthSize);
+      widthSize));
 }
 
 float YGNode::getMarginForAxis(