Allow the legacy headless.mode property to work for Chrome and Edge

lewis2i · Jul 28, 2022 · 3a83316 · 3a83316
1 parent e602b3f
commit 3a83316
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/...rc/main/java/net/serenitybdd/core/webdriver/driverproviders/ConfigureChromiumOptions.java b/...rc/main/java/net/serenitybdd/core/webdriver/driverproviders/ConfigureChromiumOptions.java
@@ -10,6 +10,9 @@
 import java.util.Arrays;
 import java.util.List;
 
+import static net.thucydides.core.ThucydidesSystemProperty.ACCEPT_INSECURE_CERTIFICATES;
+import static net.thucydides.core.ThucydidesSystemProperty.HEADLESS_MODE;
+
 public class ConfigureChromiumOptions {
 
     private final EnvironmentVariables environmentVariables;
@@ -53,5 +56,16 @@ private void applyCustomChromeOptionsTo(ChromiumOptions<?> chromeOptions) {
                     }
                 }
         );
+
+        //
+        // Headless mode from command line or headless.mode property
+        //
+        chromeOptions.setHeadless(HEADLESS_MODE.booleanFrom(environmentVariables,false));
+        //
+        // Legacy accept.insecure.certificates switch
+        //
+        chromeOptions.setAcceptInsecureCerts(ACCEPT_INSECURE_CERTIFICATES.booleanFrom(environmentVariables,false));
+
+
     }
 }
diff --git a/...core/src/main/java/net/thucydides/core/webdriver/capabilities/ChromiumOptionsBuilder.java b/...core/src/main/java/net/thucydides/core/webdriver/capabilities/ChromiumOptionsBuilder.java
@@ -14,6 +14,8 @@
 import java.util.logging.Level;
 import java.util.stream.Collectors;
 
+import static net.thucydides.core.ThucydidesSystemProperty.HEADLESS_MODE;
+
 /**
  * Build a ChromeOptions or EdgeOptions object from a set of Desired Capabilities defined in the serenity.conf file.
  */
@@ -107,6 +109,7 @@ public static ChromiumOptions<?> fromDesiredCapabilities(DesiredCapabilities cap
         } else if (capabilities.getCapability(EdgeOptions.LOGGING_PREFS) != null) {
             setChromiumLoggingPreferences(capabilities, chromiumOptions);
         }
+
         return chromiumOptions;
     }