Fix DI bug with view prototype inheritance #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximkoretskiy
force-pushed
the
feature/fix_di_prototype_bug
branch
from
e23da53 to
8e639ad
Compare
| @@ -54,4 +54,10 @@ describe "Check MixinBackbone DI",-> | |||
| view2 = @view.getViewDI @TestViewDI | |||
| expect(view2?._$_p?.removeFlag).toBe false | |||
|
|
|||
| it "correct work with prototype inheritance", -> | |||
| ParentView = Backbone.View.extend {} | |||
There was a problem hiding this comment.
Testcase isn't correct. Parentview and Childview are always have different proyotypes.
There was a problem hiding this comment.
May be You mean that they should be different? In fact you can create some view with some basic functionality and extend it in another view. And it is normal usecase. If You try to use DI while work with this views, DI will always return only the first one.
There was a problem hiding this comment.
Problem only with testcase. If revert logic functionality test will be pass. Testcase test nothing, i think. I can mistake, because can't check anythink at this moment, but my "brain intepreter" says that testcase should fails without fixing this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.