Add option for providing an external implementation of clock functions #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlingrj
commented
Feb 6, 2025
| #else // defined(LF_EXTERNAL_CLOCK_PLUGIN) | ||
| // The following empty "dummy" function is here to avoid an "Empty translation unit" compiler | ||
| // warning if the user has defined LF_EXTERNAL_CLOCK_PLUGIN to provide their own implementation. | ||
| void __clock_dummy_function(void) {} |
There was a problem hiding this comment.
We are using Werror=pedantic which throws an error on empty translation units. This dummy definition avoids that problem.
edwardalee
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for letting the user provide their own implementation of functions found in
clock.c. This enables locking the physical time the runtime sees, to a simulator.