Update bwape.c to allow equal reads in pair to be mapped as mapped in proper pair #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-processing tools like AfterQC and fastp can perform adapter clipping leaving both reads in a pair identical. This leads them to be mapped at the same location by
aln
, leading to(v).x == (u).x
in the code below. The proposed change allowssampe
to flag these as mapped in the proper pair.Using some test data, this is a distribution of fragment lengths, pre-processed using fastp, mapped with
aln
and paired withsampe
using the original code. Blue indicates mapped in proper pair (0x2 True) and red indicated otherwise (0x2 False).This is the same distribution with the proposed change:
Thanks,
Andre