tweaks to icons defaults and in buttons improve vertical align

liangbaoqiang · Nov 2, 2012 · 4b3fb30 · 4b3fb30
1 parent 72198a5
commit 4b3fb30
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/docs/assets/css/bootstrap.css b/docs/assets/css/bootstrap.css
@@ -2162,8 +2162,9 @@ table th[class*="span"],
 }
 
 [class^="glyphicon-"]:before {
-  display: inline-block;
-  font: normal 12px/1 'Glyphicons Halflings';
+  font-family: 'Glyphicons Halflings';
+  font-style: normal;
+  line-height: 1;
 }
 
 .glyphicon-glass:before {
@@ -3237,16 +3238,13 @@ button.close {
           border-radius: 3px;
 }
 
-.btn-large [class^="glyphicon-"]::before {
-  font-size: 14px;
-}
-
-.btn-small [class^="glyphicon-"]::before {
-  font-size: 10px;
+.btn [class^="glyphicon-"]::before {
+  vertical-align: -2px;
 }
 
+.btn-small [class^="glyphicon-"]::before,
 .btn-mini [class^="glyphicon-"]::before {
-  font-size: 9px;
+  vertical-align: -1px;
 }
 
 .btn-block {

diff --git a/less/buttons.less b/less/buttons.less
@@ -95,9 +95,9 @@
 // Icons in buttons
 // -------------------------
 
-.btn-large [class^="glyphicon-"]::before { font-size: 14px; }
-.btn-small [class^="glyphicon-"]::before { font-size: 10px; }
-.btn-mini [class^="glyphicon-"]::before  { font-size: 9px; }
+.btn [class^="glyphicon-"]::before       { vertical-align: -2px; }
+.btn-small [class^="glyphicon-"]::before,
+.btn-mini [class^="glyphicon-"]::before  { vertical-align: -1px; }
 
 
 // Block button

diff --git a/less/glyphicons.less b/less/glyphicons.less
@@ -32,8 +32,9 @@
 
 // Catchall baseclass
 [class^="glyphicon-"]:before {
-  display: inline-block;
-  font: normal 12px/1 'Glyphicons Halflings';
+  font-family: 'Glyphicons Halflings';
+  font-style: normal;
+  line-height: 1;
 }
 
 // Individual icons