forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[C++] Wait for all seek operations completed (apache#7216)
### Motivation When a partitioned consumer calls `seek`, it waits for only one partition's seek operation completed because each internal consumer calls `callback(result)` to complete the same `Promise`. ### Modifications - Add a `MultiResultCallback` implementation, the callback completes only if all N events completes successfully or one of N events failed. - Use `MultiResultCallback` to wrap `callback` from `PartitionedConsumerImpl::seekAsync`. * Wait for all seek operations completed * Avoid iterator invalidation during partitions update
- Loading branch information
1 parent
f475703
commit 3da6452
Showing
2 changed files
with
59 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
#pragma once | ||
|
||
#include <pulsar/ConsumerConfiguration.h> // for ResultCallback | ||
|
||
#include <atomic> | ||
#include <memory> | ||
|
||
namespace pulsar { | ||
|
||
class MultiResultCallback { | ||
public: | ||
MultiResultCallback(ResultCallback callback, int numToComplete) | ||
: callback_(callback), | ||
numToComplete_(numToComplete), | ||
numCompletedPtr_(std::make_shared<std::atomic_int>(0)) {} | ||
|
||
void operator()(Result result) { | ||
if (result == ResultOk) { | ||
if (++(*numCompletedPtr_) == numToComplete_) { | ||
callback_(result); | ||
} | ||
} else { | ||
callback_(result); | ||
} | ||
} | ||
|
||
private: | ||
ResultCallback callback_; | ||
const int numToComplete_; | ||
const std::shared_ptr<std::atomic_int> numCompletedPtr_; | ||
}; | ||
|
||
} // namespace pulsar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters