Make the FunctionRunTimeManager methods used by rest-api syncrhonized…

… since the assignment tailer also is updating it (apache#6786) This fixes the flakiness in PulsarFunctionE2ESecurityTest Co-authored-by: Sanjeev Kulkarni <[email protected]>
liangyali · Apr 21, 2020 · fb930b7 · fb930b7
1 parent c091bd7
commit fb930b7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...tions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java b/...tions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
@@ -323,7 +323,7 @@ public synchronized void removeAssignments(Collection<Assignment> assignments) {
         }
     }
 
-    public void restartFunctionInstance(String tenant, String namespace, String functionName, int instanceId,
+    public synchronized void restartFunctionInstance(String tenant, String namespace, String functionName, int instanceId,
             URI uri) throws Exception {
         if (runtimeFactory.externallyManaged()) {
             throw new WebApplicationException(Response.serverError().status(Status.NOT_IMPLEMENTED)
@@ -368,7 +368,7 @@ public void restartFunctionInstance(String tenant, String namespace, String func
         }
     }
 
-    public void restartFunctionInstances(String tenant, String namespace, String functionName)
+    public synchronized void restartFunctionInstances(String tenant, String namespace, String functionName)
             throws Exception {
         final String fullFunctionName = String.format("%s/%s/%s", tenant, namespace, functionName);
         Collection<Assignment> assignments = this.findFunctionAssignments(tenant, namespace, functionName);