Skip to content

Commit

Permalink
Fix: set scan_ranges after preparing node (StarRocks#3738)
Browse files Browse the repository at this point in the history
  • Loading branch information
ZiheLiu authored Mar 1, 2022
1 parent 680cbb1 commit 172f07f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions be/src/exec/vectorized/olap_scan_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ Status OlapScanNode::prepare(RuntimeState* state) {
}
_runtime_state = state;

RETURN_IF_ERROR(_capture_tablet_rowsets());

return Status::OK();
}

Expand Down Expand Up @@ -326,6 +324,8 @@ Status OlapScanNode::set_scan_ranges(const std::vector<TScanRangeParams>& scan_r
COUNTER_UPDATE(_tablet_counter, 1);
}

RETURN_IF_ERROR(_capture_tablet_rowsets());

return Status::OK();
}

Expand Down
3 changes: 1 addition & 2 deletions be/src/runtime/plan_fragment_executor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ Status PlanFragmentExecutor::prepare(const TExecPlanFragmentParams& request) {
static_cast<ExchangeNode*>(exch_node)->set_num_senders(num_senders);
}

RETURN_IF_ERROR(_plan->prepare(_runtime_state));
// set scan ranges
std::vector<ExecNode*> scan_nodes;
std::vector<TScanRangeParams> no_scan_ranges;
Expand All @@ -139,8 +140,6 @@ Status PlanFragmentExecutor::prepare(const TExecPlanFragmentParams& request) {
VLOG(1) << "scan_node_Id=" << scan_node->id() << " size=" << scan_ranges.size();
}

RETURN_IF_ERROR(_plan->prepare(_runtime_state));

_runtime_state->set_per_fragment_instance_idx(params.sender_id);
_runtime_state->set_num_per_fragment_instances(params.num_senders);

Expand Down

0 comments on commit 172f07f

Please sign in to comment.