PWX-38618: Add SafeEmptyTrashDir function to Mounter. #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The SafeEmptyTrashDir will take in an arbitrary trash location and a prefix which needs cleanup. - The symbolic links and the target paths will only be cleaned up if the target path has the provided prefix. fixup: review comments and added a UT Signed-off-by: Aditya Dani <[email protected]>
adityadani
force-pushed
the
PWX-38618-v2
branch
from
7357b6f to
c14bef5
Compare
Signed-off-by: Aditya Dani <[email protected]>
adityadani
force-pushed
the
PWX-38618-v2
branch
from
eb1f193 to
0c0e695
Compare
Signed-off-by: Aditya Dani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
prefix of the target matches with the provided path, to ensure we don't remove any other unrelated symbolic links.
and a prefix which needs cleanup.
path has the provided prefix.
Which issue(s) this PR fixes (optional)
Closes #
or
PWX-38618
Testing Notes
Added a UT
Special notes for your reviewer:
Add any notes for the reviewer here.