Avoid “Deprecate dynamic properties” warning in PHP 8.2 #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 deprecates access to dynamic properties, if not explicitly allowed through __set/__get or an annotation.
Therefor PHPStan fails for some reason in
\Jcupitt\Vips\ImageAutodoc
, even though it is defined in theImage
class, see for example here https://github.com/rokka-io/imagine-vips/actions/runs/3236307918/jobs/5301940309Adding __set and __get to ImageAutodoc prevents this "fail".
More details about this here https://wiki.php.net/rfc/deprecate_dynamic_properties
(PHP 8.2 is not released yet and "normal" code runs normally, just PHPStan fails currently).
This should also prevent a fatal error, if that is really removed in PHP 9.0 (__set/__get won't be removed, just implicit dynamic properties)