Fix FFI on M1 macs #198
Closed
Fix FFI on M1 macs #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleisauke
approved these changes
May 3, 2023
Comment on lines
+735
to
+740
| if (PHP_OS_FAMILY === "OSX" || | ||
| PHP_OS_FAMILY === "Darwin") { | ||
| $glib_libname = $path . $glib_libname; | ||
| $gobject_libname = $path . $gobject_libname; | ||
| $vips_libname = $path . $vips_libname; | ||
| } |
There was a problem hiding this comment.
We can probably omit this if statement and always prepend the fallback path to the library names.
Suggested change
| if (PHP_OS_FAMILY === "OSX" || | |
| PHP_OS_FAMILY === "Darwin") { | |
| $glib_libname = $path . $glib_libname; | |
| $gobject_libname = $path . $gobject_libname; | |
| $vips_libname = $path . $vips_libname; | |
| } | |
| # Ensure the fallback path is prepended to the lib names, if any | |
| $glib_libname = $path . $glib_libname; | |
| $gobject_libname = $path . $gobject_libname; | |
| $vips_libname = $path . $vips_libname; |
|
I've made #206 which I think fixes this issue. |
|
Thank you for making this PR, @iruoy. I'm sorry I was so slow getting to it, I was trapped in a terrible work crunch. I hope my PR resolves this. |
|
I actually didn't mean to close this. I was just cleaning out some repositories on my github. It looks like it caught your eye though. Thanks for making the improved PR, I will try it out this weekend or next week |
jcupitt
added a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
I don't know why, but absolute paths are needed here. Atleast on M1.