Don't convert bytes to string in Cmd (interface{} value).

lij2960 · Apr 9, 2016 · 956758d · 956758d
1 parent 1fbb109
commit 956758d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/command.go b/command.go
@@ -165,13 +165,7 @@ func (cmd *Cmd) readReply(cn *pool.Conn) error {
 		cmd.err = err
 		return cmd.err
 	}
-	if v, ok := val.([]byte); ok {
-		// Convert to string to preserve old behaviour.
-		// TODO: remove in v4
-		cmd.val = string(v)
-	} else {
-		cmd.val = val
-	}
+	cmd.val = val
 	return nil
 }
 

diff --git a/redis_test.go b/redis_test.go
@@ -132,7 +132,7 @@ var _ = Describe("Client", func() {
 		cmd := redis.NewCmd("PING")
 		client.Process(cmd)
 		Expect(cmd.Err()).NotTo(HaveOccurred())
-		Expect(cmd.Val()).To(Equal("PONG"))
+		Expect(cmd.Val()).To(Equal([]byte("PONG")))
 	})
 
 	It("should retry command on network error", func() {