don't always set logger in parse_input_line

helps startup time a bit
lilinj2000 · Jul 29, 2018 · 3a42b41 · 3a42b41
1 parent aa70c12
commit 3a42b41
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/base/client.jl b/base/client.jl
@@ -154,9 +154,14 @@ end
 
 function parse_input_line(s::String; filename::String="none", depwarn=true)
     # For now, assume all parser warnings are depwarns
-    ex = with_logger(depwarn ? current_logger() : NullLogger()) do
+    ex = if depwarn
         ccall(:jl_parse_input_line, Any, (Ptr{UInt8}, Csize_t, Ptr{UInt8}, Csize_t),
               s, sizeof(s), filename, sizeof(filename))
+    else
+        with_logger(NullLogger()) do
+            ccall(:jl_parse_input_line, Any, (Ptr{UInt8}, Csize_t, Ptr{UInt8}, Csize_t),
+                  s, sizeof(s), filename, sizeof(filename))
+        end
     end
     if ex isa Symbol && all(isequal('_'), string(ex))
         # remove with 0.7 deprecation