Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove redundant build tags #3295

Merged

Conversation

alexandear
Copy link
Member

As the file name ends with _linux.go or _windows.go, we don't need //go:build linux or //go:build windows according to https://pkg.go.dev/cmd/[email protected]#hdr-Build_constraints.

See also #1967 (comment)

Signed-off-by: Oleksandr Redko <[email protected]>
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois added this to the v1.1 (tentative) milestone Mar 2, 2025
@jandubois jandubois merged commit d1f353a into lima-vm:master Mar 2, 2025
31 checks passed
@alexandear alexandear deleted the chore-redundant-build-tags branch March 2, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants