Default value for issuedAt (spruceid#134)

* Default issuedAt to now if none * Bump version * Move issuedAt generation to toMessage function * Mark option as optinal * Fix issuedAt assignment
limindu · Oct 24, 2022 · 053f16b · 053f16b
1 parent a9c707e
commit 053f16b
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/siwe/lib/client.ts b/packages/siwe/lib/client.ts
@@ -38,7 +38,7 @@ export class SiweMessage {
    * characters. */
   nonce: string;
   /**ISO 8601 datetime string of the current time. */
-  issuedAt: string;
+  issuedAt?: string;
   /**ISO 8601 datetime string that, if present, indicates when the signed
    * authentication message is no longer valid. */
   expirationTime?: string;
@@ -112,6 +112,7 @@ export class SiweMessage {
     const suffixArray = [uriField, versionField, chainField, nonceField];
 
     this.issuedAt = this.issuedAt || new Date().toISOString();
+
     suffixArray.push(`Issued At: ${this.issuedAt}`);
 
     if (this.expirationTime) {
@@ -411,8 +412,10 @@ export class SiweMessage {
     }
 
     /** `issuedAt` conforms to ISO-8601 and is a valid date. */
-    if (!isValidISO8601Date(this.issuedAt)) {
-      throw new Error(SiweErrorType.INVALID_TIME_FORMAT);
+    if(this.issuedAt) {
+      if (!isValidISO8601Date(this.issuedAt)) {
+        throw new Error(SiweErrorType.INVALID_TIME_FORMAT);
+      }
     }
 
     /** `expirationTime` conforms to ISO-8601 and is a valid date. */

diff --git a/packages/siwe/package-lock.json b/packages/siwe/package-lock.json
diff --git a/packages/siwe/package.json b/packages/siwe/package.json
@@ -1,6 +1,6 @@
 {
   "name": "siwe",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "Sign-In with Ethereum",
   "main": "dist/siwe.js",
   "types": "dist/siwe.d.ts",