Skip to content

Commit

Permalink
Fix bug where inputs are updated from action cache but not tracked in…
Browse files Browse the repository at this point in the history
… Skyframe.

This bug, and all of them like it, will be fixed in an upcoming cl that makes sure all input metadata is obtained through Skyframe. But I think we should have this fix now.

--
MOS_MIGRATED_REVID=89540265
  • Loading branch information
janakdr authored and damienmg committed Mar 26, 2015
1 parent a258fa8 commit bad2994
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ private ActionExecutionValue checkCacheAndExecuteIfNeeded(
}

if (state.token == null) {
if (action.discoversInputs()) {
// Action may have had its inputs updated. Keep track of those new inputs.
declareAdditionalDependencies(env, action);
}
// We got a hit from the action cache -- no need to execute.
return new ActionExecutionValue(
fileAndMetadataCache.getOutputData(),
Expand Down

0 comments on commit bad2994

Please sign in to comment.