Add the release note for 1.29.0 #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trustin
reviewed
Jun 7, 2024
Comment on lines
53
to
59
| ```java | ||
| ServerBuilder sb = ... | ||
| sb.service("/foo", fooService); | ||
| ... | ||
| ServiceRequestContext ctx = ... | ||
| assert ctx.findService(FooService.class) == fooService; | ||
| ``` |
There was a problem hiding this comment.
I feel like this is not the best example. Can you use an example that uses a route decorator? CorsService could be looked for.
| ... | ||
| @Override | ||
| public ServiceOptions options() { | ||
| return customizedOptions; |
There was a problem hiding this comment.
Please make this example more useful. How about defining a static final field of ServiceOptions?
Comment on lines
112
to
113
| @Attribute(prefix = MyAttributes.class, value = "USERNAME") // 👈👈👈 | ||
| String username) { ... } |
There was a problem hiding this comment.
Suggested change
| @Attribute(prefix = MyAttributes.class, value = "USERNAME") // 👈👈👈 | |
| String username) { ... } | |
| @Attribute(prefix = MyAttributes.class, value = "USERNAME") // 👈👈👈 | |
| String username) { ... } |
| .http2GracefulShutdownTimeoutMillis(1000) | ||
| .build(); | ||
| ``` | ||
| - You can now specify an <type://EndpointGroup> to build a <type://ClientRequestContext>. #5292 #5298 |
There was a problem hiding this comment.
Suggested change
| - You can now specify an <type://EndpointGroup> to build a <type://ClientRequestContext>. #5292 #5298 | |
| - You can now specify an <type://EndpointGroup> when building a <type://ClientRequestContext>. #5292 #5298 |
|
|
||
| ## ☢️ Breaking changes | ||
|
|
||
| - Micrometer 1.13.0 uses Prometheus Java client 1.x. #5698 |
There was a problem hiding this comment.
I think this sentence is somewhat misleading. Micrometer is agnostic to metric collector implementations and it supports both Prometheus Java client versions. How about rephrasing?
Suggested change
| - Micrometer 1.13.0 uses Prometheus Java client 1.x. #5698 | |
| - We updated Micrometer to 1.13.0 that has breaking changes in its Prometheus support. #5698 |
jrhee17
approved these changes
Jun 11, 2024
| }; | ||
| } | ||
| ``` | ||
| - You can now specify when to remove multipart temporary files using <type://MultipartRemovalStrategy>. #5652 #5653 |
There was a problem hiding this comment.
Optional) It may be worth noting that the default has changed to ON_RESPONSE_COMPLETION as well.
| use the `io.micrometer:micrometer-registry-prometheus-simpleclient:1.13.0` module. | ||
| - If you want to use Prometheus Java client 1.x, add `com.linecorp.armeria:armeria-prometheus1` module. | ||
| - More details can be found in the [migration guide](https://github.com/micrometer-metrics/micrometer/wiki/1.13-Migration-Guide). | ||
| - The following builder classes are now have the `SELF` type parameter. #5733 |
There was a problem hiding this comment.
Suggested change
| - The following builder classes are now have the `SELF` type parameter. #5733 | |
| - The following builder classes now have the `SELF` type parameter. #5733 |
ikhoon
reviewed
Jun 11, 2024
|
Thanks! All addressed. 😉 |
minwoox
commented
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.